Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3777: Run Python notebooks in SDK Circle-CI #62

Merged
merged 2 commits into from
Dec 18, 2023
Merged

ENG-3777: Run Python notebooks in SDK Circle-CI #62

merged 2 commits into from
Dec 18, 2023

Conversation

JMkrish
Copy link
Contributor

@JMkrish JMkrish commented Dec 7, 2023

  1. Added Python notebooks inside 'examples' dir to SDK unit test suite.
  2. Made required changes to run the test cases in parallel using pytest-xdist.
  3. Added the required environment variables to the context 'org-sightmachine' in CircleCI's project settings.

https://sightmachine.atlassian.net/browse/ENG-3777

@JMkrish JMkrish force-pushed the ENG-3777 branch 7 times, most recently from ed6d7ef to c1ddc9f Compare December 8, 2023 15:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7985bb5) 66.60% compared to head (16a6942) 20.30%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #62       +/-   ##
===========================================
- Coverage   66.60%   20.30%   -46.31%     
===========================================
  Files          28       10       -18     
  Lines        2075     1261      -814     
  Branches      430      279      -151     
===========================================
- Hits         1382      256     -1126     
- Misses        557     1005      +448     
+ Partials      136        0      -136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JMkrish JMkrish force-pushed the ENG-3777 branch 4 times, most recently from d92044d to 4f77da8 Compare December 8, 2023 17:09
@mklein0 mklein0 self-assigned this Dec 11, 2023
.circleci/config.yml Outdated Show resolved Hide resolved
@JMkrish JMkrish force-pushed the ENG-3777 branch 2 times, most recently from a919ca1 to 0fd8517 Compare December 11, 2023 15:52
@JMkrish JMkrish requested a review from mklein0 December 11, 2023 16:01
@JMkrish JMkrish force-pushed the ENG-3777 branch 5 times, most recently from e1c7450 to 69454f2 Compare December 12, 2023 17:06
Copy link

@mklein0 mklein0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a comment on naming/labeling.

requirements-codecoverage.txt Show resolved Hide resolved
…ge.txt to requirements.txt.

Updated tenant's API-KEY and SECRETE.
@JMkrish JMkrish merged commit 79d8e5a into master Dec 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants