Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4490: Setting default value for query param '_limit'. #72

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

JMkrish
Copy link
Contributor

@JMkrish JMkrish commented Feb 14, 2024

https://sightmachine.atlassian.net/browse/ENG-4490

The absence of the '_limit' parameter in the query dictionary resulted in a misleading log message indicating that '_limit' was set to 5000. However, in reality the parameter was left unset. Consequently, the limit was automatically set to the maximum possible value like 'np.Inf' before executing the SQL query. This led to Gateway Timeout-504 issues when attempting to fetch cycles from a DB with a large number of records.

If the limit is not set in the dictionary, by programmatically setting it to 5000 resolved the Gateway timeout issues. Enabling smooth execution of the notebook at my end.

However, it needs to be addressed that if the user selects a very large value for '_limit' in the query itself, then the issue may reappear again.

@codecov-commenter
Copy link

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (c5c65bf) 23.48% compared to head (4d0c3e5) 23.25%.

Files Patch % Lines
smsdk/client_v0.py 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   23.48%   23.25%   -0.23%     
==========================================
  Files          11       11              
  Lines        1350     1363      +13     
  Branches      315      320       +5     
==========================================
  Hits          317      317              
- Misses       1033     1046      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgoldmansight mgoldmansight merged commit 54f2484 into master Feb 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants