Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressed following code review comments: #80

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Addressed following code review comments: #80

merged 1 commit into from
Apr 30, 2024

Conversation

JMkrish
Copy link
Contributor

@JMkrish JMkrish commented Apr 30, 2024 

1) Updated the performance README.md file with minor corrections.
2) Removed 'DebugInfo' message from console output.
3) Limited decimal places to 6 for metrics.
4) Added a sample JSON config file to the repository for reference.

@JMkrish
Addressed following code review comments:
5c22f9a 
	1) Updated the performance README.md file with minor corrections.
	2) Removed 'DebugInfo' message from console output.
	3) Limited decimal places to 6 for metrics.
	4) Added a sample JSON config file to the repository for reference.
@JMkrish JMkrish requested review from ankitintg and mklein0 April 30, 2024 11:16
ankitintg
ankitintg approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@ankitintg ankitintg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JMkrish JMkrish merged commit 8648fa3 into master Apr 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitintg ankitintg ankitintg approved these changes

@mklein0 mklein0 Awaiting requested review from mklein0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JMkrish @ankitintg