Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix outdir and workdir on commands #544

Merged
merged 3 commits into from
Oct 8, 2024
Merged

fix: fix outdir and workdir on commands #544

merged 3 commits into from
Oct 8, 2024

Conversation

alessiodionisi
Copy link
Contributor

@alessiodionisi alessiodionisi commented Oct 3, 2024 •
edited
Loading

Fixed get kubeconfig, get upgrade-paths and renew certificates commands.

@alessiodionisi alessiodionisi self-assigned this Oct 3, 2024
@alessiodionisi alessiodionisi changed the title fix: fix get kubconfig command fix: fix outdir and workdir on commands Oct 7, 2024
@alessiodionisi
Copy link
Contributor Author

alessiodionisi commented Oct 7, 2024 •
edited
Loading

@ralgozino could you do a test of get kubeconfig, get upgrade-paths and renew certificates commands please? thanks

ralgozino
ralgozino approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3 commands now respect the outdir when passed and do not use the $HOME/.furyctl folder anymore 🎉

I also tested setting --outdir and --workdir at the same time and everything seems to be working as expected.

well done!

@alessiodionisi alessiodionisi merged commit 217cdcc into main Oct 8, 2024
1 check passed
@alessiodionisi alessiodionisi deleted the fix-get-kubeconfig branch October 8, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralgozino ralgozino ralgozino approved these changes

Assignees

@alessiodionisi alessiodionisi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessiodionisi @ralgozino