Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upgrade path for ingress v3 #556

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

sbruzzese902
Copy link
Contributor

@sbruzzese902 sbruzzese902 commented Nov 18, 2024

This PR adds steps to migrate from ingress v2 to ingress v3.

The relevant work for ingress upgrade is:

The upgrade does not need a pre-apply phase, because new resources are added to the cluster during the apply, while the old ones are still present (to avoid downtime). Also, the patches have already been aligned to be applied on the new resources.

Here we are just removing the old unnecessary resources.

Upgrade paths included are:

  • From 1.28.4 to 1.28.5
  • From 1.29.4 to 1.29.5

Tested the second upgrade case with an On-prem cluster and the following test cases:

  • Upgrade KFD 1.29.4 -> 1.29.5:
    • Ingress updated
    • All old objects are properly deleted
    • Ingress is working with:
      • SSO
      • Without SSO
      • Dual
      • Single
      • Validating Webhook Ingress is working properly: allows creation and blocks creation of duplicated ingresses on different namespaces.
      • switch dual->none->single
      • switch single->none->dual
      • integration with monitoring:
        • NGINX dashboard
        • Alerts
  • Install on 1.29.5 clean (without upgrading):
    • Ingress is working
      • SSO
      • Without SSO
      • Dual
      • Validating Webhook Ingress is working properly: allows creation and blocks creation of duplicated ingresses on different namespaces.
      • integration with monitoring:
        • NGINX dashboard
        • Alerts

@sbruzzese902 sbruzzese902 self-assigned this Nov 18, 2024
@ralgozino ralgozino changed the base branch from feat/test-some-upgrade-paths to feat/release-v0.30.0 November 19, 2024 13:38
@ralgozino ralgozino changed the base branch from feat/release-v0.30.0 to feat/test-some-upgrade-paths November 19, 2024 13:47
@ralgozino ralgozino self-requested a review November 19, 2024 13:47
@ralgozino ralgozino marked this pull request as ready for review November 19, 2024 16:24
Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@nutellinoit nutellinoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nutellinoit nutellinoit merged commit 4444f48 into feat/test-some-upgrade-paths Nov 20, 2024
1 check passed
@nutellinoit nutellinoit deleted the feat/upgrade-1.29-1.30 branch November 20, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants