Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override global info instead of replace on __init__ #77

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

Teque5
Copy link
Collaborator

@Teque5 Teque5 commented Nov 22, 2024

Override not overwrite global information when creating new SigMFFile.

Closes #76.

Should this be the behavior for set_collection_info too?

# currently
def set_collection_info(self, new_collection):
    """
    Overwrite the collection info with a new dictionary.
    """
    self._metadata[self.COLLECTION_KEY] = new_collection.copy()

@Teque5 Teque5 requested a review from gmabey November 22, 2024 18:21
@Teque5 Teque5 requested a review from jacobagilbert November 26, 2024 17:17
@Teque5 Teque5 merged commit e83a865 into main Dec 14, 2024
6 checks passed
@Teque5 Teque5 deleted the bugfix/onto branch January 9, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overrride global info when creating new file, not replace
1 participant