-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add directory of the collection to SigMFCollection #85
Conversation
After that I'll review in more detail. |
Rewritten the unit test per above comment. |
I re-read
I believe this means that the only way the metadata is not in the same folder as the Two items for @GreenK173:
I'm not super eager to add this new top level init key |
There seems to be a misunderstanding. Yes if we have a None of the proposed changes affect the functionality for archives (and collections in an archive are not currently implemented anyway). |
Okay to make this more clear, shall we change the kwarg from Also make that property a |
Done. |
Solves #84 by adding an optional parameter
collection_path
toSigMFCollection
which is the path to the directory where the collection lives. Plus an unit test.