Remove redundant toggle Approve All members callback

signalapp · Jan 8, 2025 · 02f9e77 · 02f9e77
1 parent d95a002
commit 02f9e77
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 17 deletions.
diff --git a/.../org/thoughtcrime/securesms/calls/links/create/CreateCallLinkBottomSheetDialogFragment.kt b/.../org/thoughtcrime/securesms/calls/links/create/CreateCallLinkBottomSheetDialogFragment.kt
@@ -96,7 +96,6 @@ class CreateCallLinkBottomSheetDialogFragment : ComposeBottomSheetDialogFragment
       onJoinClicked = this@CreateCallLinkBottomSheetDialogFragment::onJoinClicked,
       onAddACallNameClicked = this@CreateCallLinkBottomSheetDialogFragment::onAddACallNameClicked,
       onApproveAllMembersChanged = this@CreateCallLinkBottomSheetDialogFragment::setApproveAllMembers,
-      onToggleApproveAllMembersClicked = this@CreateCallLinkBottomSheetDialogFragment::toggleApproveAllMembers,
       onShareViaSignalClicked = this@CreateCallLinkBottomSheetDialogFragment::onShareViaSignalClicked,
       onCopyLinkClicked = this@CreateCallLinkBottomSheetDialogFragment::onCopyLinkClicked,
       onShareLinkClicked = this@CreateCallLinkBottomSheetDialogFragment::onShareLinkClicked,
@@ -124,15 +123,6 @@ class CreateCallLinkBottomSheetDialogFragment : ComposeBottomSheetDialogFragment
     }, onError = this::handleError)
   }
 
-  private fun toggleApproveAllMembers() {
-    lifecycleDisposable += viewModel.toggleApproveAllMembers().subscribeBy(onSuccess = {
-      if (it !is UpdateCallLinkResult.Update) {
-        Log.w(TAG, "Failed to update call link restrictions")
-        toastFailure()
-      }
-    }, onError = this::handleError)
-  }
-
   private fun onAddACallNameClicked() {
     val snapshot = viewModel.callLink.value
     findNavController().navigate(
@@ -242,7 +232,6 @@ private fun CreateCallLinkBottomSheetContent(
   onJoinClicked: () -> Unit = {},
   onAddACallNameClicked: () -> Unit = {},
   onApproveAllMembersChanged: (Boolean) -> Unit = {},
-  onToggleApproveAllMembersClicked: () -> Unit = {},
   onShareViaSignalClicked: () -> Unit = {},
   onCopyLinkClicked: () -> Unit = {},
   onShareLinkClicked: () -> Unit = {},
@@ -291,7 +280,6 @@ private fun CreateCallLinkBottomSheetContent(
         checked = callLink.state.restrictions == CallLinkState.Restrictions.ADMIN_APPROVAL,
         text = stringResource(id = R.string.CreateCallLinkBottomSheetDialogFragment__require_admin_approval),
         onCheckChanged = onApproveAllMembersChanged,
-        modifier = Modifier.clickable(onClick = onToggleApproveAllMembersClicked),
         isLoading = isLoadingAdminApprovalChange
       )
 

diff --git a/app/src/main/java/org/thoughtcrime/securesms/calls/links/create/CreateCallLinkViewModel.kt b/app/src/main/java/org/thoughtcrime/securesms/calls/links/create/CreateCallLinkViewModel.kt
@@ -99,11 +99,6 @@ class CreateCallLinkViewModel(
       }
   }
 
-  fun toggleApproveAllMembers(): Single<UpdateCallLinkResult> {
-    return setApproveAllMembers(_callLink.value.state.restrictions != Restrictions.ADMIN_APPROVAL)
-      .observeOn(AndroidSchedulers.mainThread())
-  }
-
   fun setCallName(callName: String): Single<UpdateCallLinkResult> {
     return commitCallLink()
       .flatMap {