-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdMob #1813
Comments
LBE Security Master also marks Textsecure as containing ads. It does not tell, what ads, but I find it a little disturbing. |
Twitter bought WhisperSystems a while ago and is making RedPhone an open sourse project now. TexSecure got and is getting a bit of a make over with new things being added. I just hope they aren't selling out customers with a free app only to sell off their info for a bit of cash. Can anyone from WhisperSystems answer with a reply? |
TextSecure is not owned by Twitter You should read this: |
People make money with Admob by showing ads. Do you see any ads? That should tell you how reliable those services are. Scaremongers. |
AdMob is not only for showing ads. It also collects user information with Analytics. This is not acceptable for thus Art of App. |
I guess its a false positive, search the code for AdMob, you won't find it... https://github.com/WhisperSystems/TextSecure/search?q=admob&ref=cmdform&type=Code |
No, it does not. Admob by itself collects no usage data if you don't show any ads. Google Analytics is a totally different API. Regardless, TextSecure uses none of those APIs. I've used both in other apps, and they aren't used here. It's quite easy to see that they're not being used, and the onus should be on those scaremongering companies to prove their claims, not on WhisperSystems to disprove them. |
It seems to be true that Text Secure is not containing any adware. However, it is not nice to get such false results. What could be wrong? |
The competence of those entities providing said results is clearly lacking. |
We definitely do not have ads in TextSecure. Very obvious false positive. |
We'll see if they respond: |
Twitter doesn't own WhisperSystems? Then I guess Forbes got it wrong....lol. http://www.forbes.com/sites/andygreenberg/2011/11/28/twitter-acquires-moxie-marlinspikes-encryption-startup-whisper-systems/ . Also, I think Google has deliberately inserted AdMob (Google bought AdMob in 2009 http://techcrunch.com/2009/11/09/google-acquires-admob/) into aps. I have a Samsung note 8 tablet. I had no issues until the latest firmware upgrade which included a patch for the Master Key & Fake ID certs from Google (as reported by BlueBox Security & by Steve Gibson on his Security Now podcast.). Could it be a false posative from TrustGo? Sure. Just odd that it and several others popped up after the firmware update & Google patches. |
That was 2011 - Open Whisper Systems has nothing to do with Twitter: https://www.whispersystems.org/blog/welcome/ Also, if Google tampered with the APKs, that would be really easy to detect. Just check if the signature is valid (and the signing key used is in fact the one used by @moxie0 - Moxie would you publish the public key somewhere?) |
There is a difference between "WhisperSystems" and "Open WhisperSystems". See: https://www.whispersystems.org/blog/welcome/ It is a false positive, just look at the code and compile it yourself... edit: tinloaf was faster |
Thanks for the feedback and suggestions fellas. BTW, did TrustGo ever respond? |
* Initial fix for regression test failure 1.1 * Added permissions fix for sharing documents which should allow for thumbnail generation * Minor touch-up prior to merge into dev * Fixes signalapp#1813 * Fixes signalapp#1472 - please ignore previous fixes 1813 statement, I'd used the Jira ticket number rather than creating a GitHub issue and using that --------- Co-authored-by: alansley <[email protected]>
* Remove unused sizeResId * Fix caching * Prefix message with name in HomeActivity * Hide sender prefix for note to self * Hide sender prefix for control messages * Remove problematic getLastMessage() * Refactor snippet formatting * Remove unused RecoveryPhraseRestoreActivity * Fix unresolved theme attributes exception * Fix dialog button style * Investigation in progress * Working fix push before cleanup * Fixes signalapp#1346 * Removed unused logging imports * Put back some whitespace * Minor cleanup * Fix NPE on null display name * fix: disappearing viewmodel tests (#1432) * SES-1354 - Video call self viewer not mirrored (#1397) * Fixes signalapp#874 * Removed accidentally left in line * Fixed issue - push before cleanup * Cleaned up * Removed cruft --------- Co-authored-by: = <=> Co-authored-by: AL-Session <[email protected]> * SES-1145 - New messages are hidden under keyboard - MK3 (#1415) * WIP * Working - push before cleanup * Fixes signalapp#1316 * Cleanup * PR review adjustments * Fixed scrolling when receiving an image based message while keyboard is up * Prevent auto-scroll to last seen item pos in conversation view if <= 3 * Put back <=3 check to scroll --------- Co-authored-by: = <=> Co-authored-by: AL-Session <[email protected]> * Fix missing parenthesis * SES-789 - Scroll to bottom of long new message(s) (#1426) * WIP * Working - push before cleanup * Fixes signalapp#1316 * Cleanup * PR review adjustments * Fixed scrolling when receiving an image based message while keyboard is up * Prevent auto-scroll to last seen item pos in conversation view if <= 3 * Put back <=3 check to scroll * Forced scrolling to bottom of long messages (both sent and received) when already at the bottom of the RecyclerView * Fixes signalapp#1364 --------- Co-authored-by: = <=> Co-authored-by: AL-Session <[email protected]> * SES-1352 - User and group names allowing multi-line strings (#1395) * Fix WIP * Resolved issue - pushing before cleanup & PR tomorrow morning * Enforced single line for new closed group names * Fixes signalapp#1394 * Final cleanup prior to PR * Added code to restore a previous contact nickname if an empty one is given * Added initial limits to nicknames and group names, both creation and display * Minor adjustments * Adjusted max nickname and group name to 35 chars as per Kee's instructions * Fixed closed group edit text able to get too wide and cut off buttons --------- Co-authored-by: = <=> Co-authored-by: AL-Session <[email protected]> Co-authored-by: Al Lansley <[email protected]> * SES-212 - Always show delivery status of last sent message - FINAL! (#1418) * Fixes signalapp#1408 * Addressed PR feedback * Cleanup * PR adjustments * Further PR adjustments * Updated libsession-util * Added fix for crash when no messages * Ignoring dirty submodules so they don't show up in git * Re-fixed display of delivery status on last sent message (got broken by disappearing messages) * Removed ignore dirty modules line in .gitmodules as it all seems to be playing nice now --------- Co-authored-by: AL-Session <[email protected]> Co-authored-by: Al Lansley <[email protected]> * fix: use a set for the from/to serialized lists (#1370) * Fixes signalapp#1347 (#1396) Co-authored-by: AL-Session <[email protected]> Co-authored-by: Al Lansley <[email protected]> * SES-1156 - Ban and delete functionality fix (#1428) * WIP * Investigation in progress * End of day push * WIP * Fixes signalapp#1416 * Cleanup * Added code to remove zombie messages caught in limbo during a ban & delete - still chock full o' debug while finding root cause * Root cause debug WIP * Push prior to cleanup * Cleaned up for PR * fix: mms delete, remove unnecessary values from sms * Addressed PR feedback * fix: fix unit tests * Added '.run' folder with test setup * Update README.md Test commit for CI * Re-added accidentally removed closing brace --------- Co-authored-by: alansley <[email protected]> Co-authored-by: Al Lansley <[email protected]> Co-authored-by: 0x330a <[email protected]> * SES-1356 - List of recently used reaction emojis is not accurate (#1400) * WIP * Further WIP * Push prior to cleanup * Fixes signalapp#1015 * Added limiting to the count of recently used emoji that we store * Put back adjusted reaction pill layout to standard * Adjusted recently used reaction emojis already in list to go to start of list --------- Co-authored-by: = <=> * SES-697 - Add loading state when exporting logs (#1402) * WIP * Fixes signalapp#1401 * Cleanup from PR view * Final cleanup * Removed commented line of code & re-ordered comment * Addressed PR feedback * Re-allowed loading of avatars to throw exceptions rather than return null on failure --------- Co-authored-by: = <=> * SES-1251 - App crash on non alphanumeric first char search (#1393) * Investigation in progress * Working fix push before cleanup * Fixes signalapp#1346 * Removed unused logging imports * Put back some whitespace * Minor cleanup * Push before cleanup * Fixes signalapp#1346 - properly this time! * SES1567 - Community message delivery status fix (#1442) * Initial investigation * WIP * Continued work to track down cause of delivery status issue * Fixes signalapp#1438 * Cleanup for PR * Further cleanup * Fixed merge conflict * Addressed PR feedback --------- Co-authored-by: alansley <[email protected]> * Tiny adjustment to center user name in Settings activity (#1446) * Addressed PR feedback * Cleanup * Initial fix implemented * Fixes signalapp#1448 * Addressed PR feedback * SES1688 - Deleting last message in conversation, group, or community leaves the RecyclerView in a broken state (#1449) * Initial fix implemented * Fixes signalapp#1448 * Addressed PR feedback * Handle case where there are no messages * build: update build number * Fix spacing when title is absent * Hide reply button in MessageDetails for group invitations * Remove reply from context menu for open group invitations * Ignore swipe reply to open group invitation * Fix multiple quote previews * Fix message menu icons not visible in light theme * Hide reply app bar menu item for open group invite * SES-1727 Mentions text is the wrong colour (#1454) * Fixes signalapp#1453 * Cleanup * Code review adjustments * Adjusted mentions to use the accent colour as their background colour when using light themes --------- Co-authored-by: alansley <[email protected]> * Disable swipe to reply on open group invites * Fix multiple link previews * SES1718 - Message Sending Status (#1462) * Investigation in progress * Initial push for PR * Fixes signalapp#1461 * Removed leftover debug comments * Added minor optimisation to showMessageStatus method (bail early if the message isn't one we care about displaying details of to the user) * Minor cleanup * Tiny cleanup * Addressed PR feedback * Removed forgotten debug log line & forced delivery status elements to be removed on non-visible messages just in case * Minor refactor to simplify 'VisibleMessageView.showStatusMessage' --------- Co-authored-by: alansley <[email protected]> * Fix margins * WIP * Commit before converting SmsDatabase from Java to Kotlin * Remove old expiration config strings from UpdateMessageBuilder * Fix group expiration update config messages * Fixed conversation view closing + hopefully wrong status text displayed + deletion of contact on removal of last message in 1-on-1 convo * Cleanup for PR review * Implemented PR feedback * Don't start expiration for group expiration update messages * Fix expiry update message for groups * Correctly don't start disappear timer on group timer updates * SES1813 - Fix regression test failures (#1473) * Initial fix for regression test failure 1.1 * Added permissions fix for sharing documents which should allow for thumbnail generation * Minor touch-up prior to merge into dev * Fixes signalapp#1813 * Fixes signalapp#1472 - please ignore previous fixes 1813 statement, I'd used the Jira ticket number rather than creating a GitHub issue and using that --------- Co-authored-by: alansley <[email protected]> --------- Co-authored-by: alansley <[email protected]> Co-authored-by: 0x330a <[email protected]> Co-authored-by: Al Lansley <[email protected]> Co-authored-by: AL-Session <[email protected]> Co-authored-by: Al Lansley <[email protected]>
As of today, TrustGo Security Ad detector shows TexSecure as having AdMob installed in the background on Android. Did Google do the dirty on us or did TextSecure really add AdMob (which collects all your info and sells it)?
The text was updated successfully, but these errors were encountered: