Enforce no grouping in currency formatter, to be consistent with Mone… #13923
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…yFilter. Fixes #13922
First time contributor checklist
Contributor checklist
Fixes #1234
syntaxDescription
When pasting long numbers into the Custom Donation field, the grouping separator was being formatted in, causing further edits to the text to not work. The formatter needed to format the number without these separators (e.g. $1000 vs $1,000).
To verify the bug as en_US Locale, paste "12345" into the donate custom amount field. See it formatted as "$12,345". See that you cannot delete digits until you delete the comma. Also notice the NumberFormatException being caught for the withoutLeadingZeroes code.
After fix, it should format as "$12345", consistent with typing in the digits manually. NumberFormatException no longer being thrown.
Also tested with
Thoughtcrime
$12,345
12345
12,345
$12,345.00
12,345.00
12345.00
$0012345
$0012,345
532&12345
1,23
0012345
0012345.00
0012345.00$
Unexpected formats are disallowed from being pasted in, and leading zeroes are removed.