Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate whether or not last message is yours #3012

Closed
wants to merge 2 commits into from
Closed

Indicate whether or not last message is yours #3012

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 18, 2015

This should be a fix for #1363 (plus I fixed a typo)
Sorry if the PR looks like a mess, it's my first attempt to use github. Hope it's fine

@ChaoticMind
Copy link

Try out git rebase -i 586b743, it lets you squash your commits and the PR will have a cleaner history.

@ghost
Copy link
Author

ghost commented Apr 18, 2015

Thanks! I think it worked.

} else {
return new SpannableString(getBody().getBody());
}
return new SpannableString(getBody().getBody());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong indentation level.

@chr1shaefn3r
Copy link
Contributor

I would favour a solution where I would also have the "delivered" information in the contact list. So additionally to the information that I send the last message, I would also know that it was delivered to the recipient.

@agrajaghh
Copy link
Contributor

I agree, delivered would be helpful. What about some icons, maybe on the right side below the date?
checkmark for deliverd, arrow (to the right?) for sent messages and perhaps arrow to the left for received messages?

@ghost
Copy link
Author

ghost commented Apr 21, 2015

Looks like that would require a little more time to develop, and considering I don't have the icons... anyone is welcome to trash my PR and open another one :-)
edit: I mean I like the idea of icons, but my PR was to temporarily fix something that was bugging me. I'm expecting a major redesign when the app turns into Signal anyway... right?

@agrajaghh
Copy link
Contributor

@volcano99 I could assist you with the icon's if thats helping you?

@ghost
Copy link
Author

ghost commented Apr 21, 2015

My main problem is that I don't have a ton of experience coding, so I'm afraid I'd end up slowing things down :/
Plus, first I want to hear from the official developers if they'd like the idea. Do you already know of any icons?

@agrajaghh
Copy link
Contributor

I don't think its a really urgent issue, and the best way of gaining experience is just to try ;)

But you're right lets wait what the main devs will say...

Just made a quick mockup, but I'm not totally pleased with it though....
I tried the TS checkmark and a normal one .. I think the simple one looks better.
3012

@ghost
Copy link
Author

ghost commented Apr 21, 2015

The normal one looks SO much better, why is it not being used in conversations too?
(Just a thought... we need a pair of icons for each type, because they will change depending on the theme...)

@mcginty
Copy link
Contributor

mcginty commented Nov 17, 2015

Closing since this account was deleted. I'm in favor of displaying the delivery status of a message instead of a "You: " in the summary, since it provides even more information and still lets the user know it was a message sent from them.

@mcginty mcginty closed this Nov 17, 2015
@ghost ghost mentioned this pull request Oct 9, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants