-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-Focus of input-field after app regains focus #1096
Comments
Is there a system for upvoting 👍 issues that we agree with, other than the GitHub reactions? One that the maintainers track and use to help guide the roadmap? |
Today, the app persists whatever focus you had when you left the app. So if you had the message composition field focused, it will stay focused when you come back. If you had a message highlighted because you wanted to refer back to it as you were doing something, we'll leave that selection in place too. Can you describe the detailed scenario where you've lost focus on the message composition field, then leave the app, then come back but want it highlighted again? What caused you to lose focus on the message box in the first place? |
@scottnonnenberg the use case I find annoying can be reproduced by the following:
I think this may be a consequence of Chrome extension behavior, not Signal-specific. |
@mecampbellsoup Thanks for the additional detail. Yes, there is absolutely some Chrome App windowing weirdness. But I've found that when I do get back to the right Signal App (I sometimes have 4 or more running!), the focus is still in the right place. |
@jwillem are you still able to reproduce this issue? What do you mean by...
? |
Sorry, I’ve meant that you click outside of the input, so that the caret loses focus.
… On 26. Jul 2017, at 19:42, Matt Campbell ***@***.***> wrote:
@jwillem <https://github.com/jwillem> are you still able to reproduce this issue? What do you mean by...
prevent focus on input-field
?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1096 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH18FB5yPSTIUW5lMIUAzC8752kIBbL1ks5sR3qNgaJpZM4Mg7PC>.
|
The focus is preserved in fact, but only if the input field had focus before.
|
@jwillem I went back in and tried your detailed scenario, couldn't get it to happen. If I've clicked outside of the message composition text box, I can still hit tab to eventually get there. So I'm wondering if there are other factors involved here. How did you start the app? Did you start Signal from Mission Control? Or the |
This is what I find annoying. In my opinion the input-filed should be auto-selected, if typing occurs. At least Telegram has it that way. |
I'm not sure if this is the right place or if I should create a new ticket: When you look at the behaviour of Telegram, WhatsApp, Messenger (desktop and or web apps) they all not only make sure that after switching to a new thread the input field is focused but also that clicking somewhere into the message log of the current thread the focus actually stays with the input field (or at least that it immediately regains focus upon starting to type). I think the above behaviour is the expected and sensible one unless there is a very good reason not to behave like this. I also recall that some of the messaging apps I've been using (might also have been Slack) did not originally behave like this and it left me with the impression that their UX is 'bad' without being able to pinpoint why I had the feeling (until I noticed the described behaviour eventually). I think this is a huge (ux-)issue especially for people who are used to the other very popular messaging apps and should be (re-) prioritized if possible. |
👍 |
One other scenario I hit constantly is when somebody sends me a link and I want to reply right after seeing it. I switch back the app and start typing only to realize the focus is still in the conversation area and I'm not typing anything. I've become accustomed to double tap A simple solution (solving at least my use case) would be to add a check when the app regains focus. The callback would check whether there's some text selected (highlighted) in the conversation area. If so, do nothing. Otherwise focus the input field. |
Just chiming in to say I noticed a similar UX hiccup when clicking into the conversational area removes the focus of the text input box. Compare to, say, Google Hangouts, where any click within anywhere pertaining to the conversation still leaves the cursor in the text box active. An example is if you click to a link your conversation partner has sent you, view the link in a browser, and then alt-tab or command-tab to return back to Signal, the "conversation" is active but the text input field is not, and you have to manually re-select the input box in order to re-engage in conversation. I think the Hangouts way of doing it, where there's no such thing as an "active" conversation - you can engage to highlight and copy text, to clink on links, but your focus doesn't persist there - is ideal for me as a user. Thanks! |
Is there any ETA on this? Should this be on the roadmap? In my opinion, it is quite big UI bug, which could sway newcomers away from the platform. |
Hello from 2018. I have made a PR that attempts to fix this issue: #2885 It simply autofocuses the text input when the conversation view is focused, unless a panel or audio capture is active. |
Bug description
Steps to reproduce
Actual result: No Input-Field has Focus. (Therefore a User needs to click the input-field to type in it)
Expected result: Input-field of the last conversation should be automatically focused.
Platform info
Operating System: OSX
Browser: Chrome 56.0.2924.87
Signal version: 0.33.0
The text was updated successfully, but these errors were encountered: