Add Right-Click to save images #3350
Labels
Comments
vinhowe
added a commit
to vinhowe/Signal-Desktop
that referenced
this issue
Oct 27, 2020
Wire up context menu handlers to support copying locally stored images to system clipboard. Making this work in the Lightbox component seems like a good first step--it means not dealing with the confusing click handling mechanics on Message, ImageGrid, and Image. This follows the behavior of Slack's desktop app pretty closely except that I didn't include an option to copy the link because it's an ugly hidden local directory. This scratches a personal itch. I very often use the Note to Self feature to send images between computers, and I usually just want to copy them instead of downloading them. Should go a long way toward addressing signalapp#3350.
7 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Description
Follow-up request from #3197 to expand the context menu to add Copy to images. Currently to save an image you need to click on the three dots and save it locally then open it in another application and copy it there. This request is that you be able to directly right click an image to copy it.
Changes required
I believe this can be accomplished using electron-context-menu which was added in #3197.
The element added in the same div container with each image
<div class="module-image__border-overlay module-image--curved-top-left module-image--curved-top-right"></div>If this element is removed electron-context-menu can pick up on images, but an additional change would be required to accomplish the same look. Though from what I can tell it doesn't appear to do much.
By default electron-context-menu only exposes "Save image" when right-clicking an image and doesn't provide a "Copy" option. To be investigated if that is a configuration or inherent limitation.
Signal Desktop uses custom emoji instead of system emoji, they are represented by images, and thus can be right-click "Save image"'d. A new css element which obscures the emoji is required.
Profile images can be right-click "Save image"d. Its not clear if this is an issue.
The text was updated successfully, but these errors were encountered: