Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Switch to our fork of Neon with faster EventQueue operations #308

Merged
merged 1 commit into from
May 20, 2021

Conversation

jrose-signal
Copy link
Contributor

@jrose-signal jrose-signal commented May 19, 2021

Copy link
Contributor

@indutny-signal indutny-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely familiar with the crate resolution system, but shouldn't all neon references point to git? Also, there are bunch of other Cargo.toml that have neon. Should they be updated?

Given my lack of expertise this LGTM, though, provided that it builds.

rust/bridge/node/Cargo.toml Show resolved Hide resolved
@jrose-signal
Copy link
Contributor Author

jrose-signal commented May 19, 2021

The workspace-level Cargo.toml serves as an override for everything in the workspace (though not for someone outside the workspace depending on one of these crates). The same mechanism is used for our forked curve25519-dalek.

As for features, they're additive, so this effectively says "you can build signal-neon-futures (and libsignal-bridge) not depending on napi-4, but when you actually build the libsignal-node that gets shipped you should have napi-6 enabled".

@jrose-signal jrose-signal force-pushed the jrose/use-neon-fork branch from f747028 to 203d682 Compare May 19, 2021 22:12
@jrose-signal jrose-signal force-pushed the jrose/use-neon-fork branch from 203d682 to 9748c25 Compare May 20, 2021 00:49
@jrose-signal jrose-signal merged commit ceef64e into master May 20, 2021
@jrose-signal jrose-signal deleted the jrose/use-neon-fork branch May 20, 2021 01:08
jrose-signal added a commit that referenced this pull request May 20, 2021
Node: Switch to our fork of Neon with faster EventQueue operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants