timefield can be string type for existing schema. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgheewala
force-pushed
the
time_field_fix
branch
from
58c3be8 to
b9232a2
Compare
sjkaris
reviewed
Jun 12, 2020
| @@ -41,6 +41,15 @@ message Value { | |||
| } | |||
| } | |||
|
|
|||
| // some existing schemas have time field as string and hence we should be able to accept such | |||
| // time field into the system. Parsing of such fields will happen at data store layer | |||
| message TimeField { | |||
There was a problem hiding this comment.
Is there not an easy way to standardize the time field in logs-ingest?
There was a problem hiding this comment.
@sjkaris we would have to parse the field at log-ingest layer (and that is not cheap). Given that SCS already does the parsing of such timefield's, I think log-ingest should just do basic validation and forward it
There was a problem hiding this comment.
Note: log-ingest would do validation of string representation to filter out invalid formats like "multiple dots", "non-numeric", etc
mdubbyap
approved these changes
Jun 12, 2020
sk-sfx
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given that SCS already does parsing of the incoming "time" in different format, it makes me think that we should do simple validation check at log-ingest layer and let the data store do the rest. The change will allow us to accept "string" types into the proto format and then let the last downstream service deal with it