Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance golangci-lint #44

Merged
merged 1 commit into from
May 25, 2022
Merged

Enhance golangci-lint #44

merged 1 commit into from
May 25, 2022

Conversation

keitwb
Copy link
Contributor

@keitwb keitwb commented May 24, 2022

No description provided.

@keitwb keitwb requested review from swahba and jgheewala May 24, 2022 19:08
@keitwb keitwb force-pushed the lint-fix branch 3 times, most recently from 6189725 to d03e58b Compare May 24, 2022 19:55
@keitwb keitwb requested a review from mdubbyap May 24, 2022 20:33
This also makes the repo use github actions for linting
@keitwb
Copy link
Contributor Author

keitwb commented May 25, 2022

Ok, @swahba take a look again. I did change some of the otlp metric parsing code to make it a bit more efficient and to get rid of the linting issues regarding copying protobuf structs.

@swahba
Copy link
Contributor

swahba commented May 25, 2022

Ok, @swahba take a look again. I did change some of the otlp metric parsing code to make it a bit more efficient and to get rid of the linting issues regarding copying protobuf structs.

Thanks a lot, @keitwb . This looks great.

@keitwb keitwb merged commit 905b3b0 into master May 25, 2022
@keitwb keitwb deleted the lint-fix branch May 25, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants