Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cri-o log format time layout #817

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

jvoravong
Copy link
Contributor

@jvoravong jvoravong commented Jun 21, 2023

Related Issues (duplicates):

Description:

  • Adopting a bug fix from the community. Basically the root cause of the bug being fixed is containerd log formats are not as finalized as CRI-O and Docker log formats. containerd log formats have recently changed in some K8s environments to look very much like CRI-O log formats.
  • The community has updated the CRI-O parser to accept containerd logs that are formatted very similarly to CRI-O logs, which fixes this bug. We may only need one parser for CRI-O and containerd logs in the future.
  • Keeping our current containerd parser would be a good idea for now for having legacy containerd format support.

@jvoravong jvoravong requested review from a team as code owners June 21, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants