Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip publishing splunk-otel-javaagent-all.jar #1567

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

laurit
Copy link
Collaborator

@laurit laurit commented Jan 4, 2024

No description provided.

@laurit laurit requested review from a team as code owners January 4, 2024 12:58
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I thought we got rid of or stopped publishing that a long time ago...but maybe I'm thinking of upstream.

@breedx-splk
Copy link
Contributor

Actually, we might have some internal uses that rely on that name. Let's chat offline.

@laurit
Copy link
Collaborator Author

laurit commented Jan 5, 2024

Weird, I thought we got rid of or stopped publishing that a long time ago...but maybe I'm thinking of upstream.

Yes upstream removed it a long time ago, we deprecated it in https://github.com/signalfx/splunk-otel-java/releases/tag/v1.8.0

@breedx-splk
Copy link
Contributor

Cool, I think the other mitigations we have in place now should be enough. I'm ok with merging this. Thanks!

@laurit laurit merged commit c73b945 into signalfx:main Jan 9, 2024
32 checks passed
@laurit laurit deleted the skip-all-artifact branch January 9, 2024 12:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants