Add a flag for choosing metrics implementation #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurbiztondo-splunk
approved these changes
Jul 11, 2022
...mon/src/main/java/com/splunk/opentelemetry/instrumentation/MetricsInstrumentationModule.java
Outdated
Show resolved
Hide resolved
| // implementation in the next release."); | ||
|
|
||
| // by default no otel metrics are exported | ||
| addIfAbsent(builder, config, "otel.metrics.exporter", "none"); |
There was a problem hiding this comment.
This will enable otel metrics if splunk.metrics.implementation is set to opentelemetry, even if splunk.metrics.enabled is false (same for the list of instrumentations below).
Perhaps we should keep them all disabled in defaultProperties() and only enable them when a particular implementation is chosen and metrics are enabled?
…instrumentation/MetricsInstrumentationModule.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
aurbiztondo-splunk
approved these changes
Jul 12, 2022
…ion.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
mateuszrzeszutek
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.