Fix MIME multipart handling and RFC4103 Real-Time Text #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is vital i.e. for routing RFC6442 Geolocation information
… Fix bug that always used RTP RED, even when not advertised by peer leading to garbled text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing on MIME Multipart SIP message, i.e. ones with Geolocation information attached, the Content-ID was not passed on so that the Geolocation Header did not point to a valid content-id, rendering the information unusable.
On Real Time Text, passing through did not work because of lacking handling of the sendrecv flag.
When passing on RTT without RTPRED support, Freeswitch always tried to pass on the text als RTPRED, as variable was set, even when peer didn't support RTPRED. This lead to crippled text mesages due to wrong handling.