feat(ts): Mise en place du typage dans fonctions JavaScript #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggestion de Christophe via Slack: Je suis d'accord. |
for consistency with current way of bundling
adrienjoly
commented
Apr 21, 2020
| (prenom4_unite_legale || '') + ' ').trim() + '/' | ||
|
|
||
| return(raison_sociale) | ||
| function raison_sociale(denomination_unite_legale, nom_unite_legale, nom_usage_unite_legale, prenom1_unite_legale, prenom2_unite_legale, prenom3_unite_legale, prenom4_unite_legale) { |
There was a problem hiding this comment.
Ce fichier étant désormais généré par transpilation TypeScript depuis raison_sociale.ts, son formattage est un peu différent.
Il serait idéal de ne plus stocker dans git les fichiers JS résultats de transpilation, mais à noter que les tests existants s'appuient sur jsc pour tester ces fonctions, et donc sur leur format JS et non TS.
adrienjoly
commented
Apr 21, 2020
adrienjoly
commented
Apr 21, 2020
adrienjoly
changed the title
adrienjoly
changed the title
chrnin
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Première étape visant à rendre plus robuste le développement et l'exécution des fonctions JavaScript employées par le map-reduce de MongoDB, en typant puis transpilant ces fonctions à l'aide de TypeScript.
Pour tester la chaine de transpilation (provisoire):