Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Export slashing protection per validator #2674

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Part of #2557

Proposed Changes

Refactor the slashing protection export so that it can export data for a subset of validators.

This is the last remaining building block required for supporting the standard validator API (which I'll start to build atop this branch)

Additional Info

Built on and requires #2598

@michaelsproul michaelsproul added the work-in-progress PR is a work-in-progress label Oct 5, 2021
@michaelsproul
Copy link
Member Author

Needs some tests and a CLI update before merging

@michaelsproul michaelsproul force-pushed the slashing-protection-indiv-export branch from e3c62f9 to b33c741 Compare October 6, 2021 03:09
@michaelsproul
Copy link
Member Author

Needs some tests and a CLI update before merging

Done. Now just blocked on #2598

@michaelsproul michaelsproul marked this pull request as ready for review October 6, 2021 03:10
@michaelsproul michaelsproul added blocked ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Oct 6, 2021
@michaelsproul michaelsproul force-pushed the slashing-protection-indiv-export branch from b33c741 to 0b177a8 Compare October 7, 2021 23:21
@paulhauner
Copy link
Member

I'll give this a review once #2598 is merged :)

@michaelsproul michaelsproul force-pushed the slashing-protection-indiv-export branch from 0b177a8 to e44da24 Compare October 13, 2021 04:51
@michaelsproul
Copy link
Member Author

Rebased on unstable and ready for review once CI passes

@michaelsproul
Copy link
Member Author

Re-running CI as cargo-deps failed with a network error

Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 19, 2021
@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 19, 2021
## Issue Addressed

Part of #2557

## Proposed Changes

Refactor the slashing protection export so that it can export data for a subset of validators.

This is the last remaining building block required for supporting the standard validator API (which I'll start to build atop this branch)

## Additional Info

Built on and requires #2598
@bors bors bot changed the title Export slashing protection per validator [Merged by Bors] - Export slashing protection per validator Oct 19, 2021
@bors bors bot closed this Oct 19, 2021
@michaelsproul michaelsproul deleted the slashing-protection-indiv-export branch October 19, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants