Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Poll the engine_exchangeTransitionConfigurationV1 endpoint #3047

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Poll the engine_exchangeTransitionConfigurationV1 endpoint #3047

wants to merge 6 commits into from

Conversation

paulhauner
Copy link
Member

@paulhauner paulhauner commented Feb 28, 2022 •
edited
Loading

Issue Addressed

There has been an engine_exchangetransitionconfigurationv1 method added to the execution API specs.

The engine_exchangetransitionconfigurationv1 will be polled every 60s as per this PR: ethereum/execution-apis#189. If that PR is merged as-is, then we will be matching the spec. If that PR is not merged, we are still fully compatible with the spec, but just doing more than we are required.

Additional Info

@paulhauner paulhauner added blocked work-in-progress PR is a work-in-progress bellatrix Required to support the Bellatrix Upgrade labels Feb 28, 2022
@paulhauner paulhauner removed the blocked label Mar 1, 2022
paulhauner added a commit that referenced this pull request Mar 3, 2022
@paulhauner
Squash merge of #3047
bc07143 
Squashed commit of the following:

commit b870f70
Author: Paul Hauner <[email protected]>
Date:   Tue Mar 1 10:06:37 2022 +1100

    Add transition config method
@paulhauner paulhauner removed the work-in-progress PR is a work-in-progress label Mar 4, 2022
paulhauner added a commit that referenced this pull request Mar 4, 2022
@paulhauner
Squash merge of #3047
c1f15d9 
Squashed commit of the following:

commit 3f287d0
Author: Paul Hauner <[email protected]>
Date:   Fri Mar 4 10:46:26 2022 +1100

    Fix method naming

commit b870f70
Author: Paul Hauner <[email protected]>
Date:   Tue Mar 1 10:06:37 2022 +1100

    Add transition config method
@paulhauner paulhauner added the ready-for-review The code is ready for review label Mar 4, 2022
paulhauner added a commit that referenced this pull request Mar 4, 2022
@paulhauner
Squash merge of #3047
8537e81 
Squashed commit of the following:

commit b5a711f
Author: Paul Hauner <[email protected]>
Date:   Fri Mar 4 13:10:57 2022 +1100

    Remove "number" rename

commit 3f287d0
Author: Paul Hauner <[email protected]>
Date:   Fri Mar 4 10:46:26 2022 +1100

    Fix method naming

commit b870f70
Author: Paul Hauner <[email protected]>
Date:   Tue Mar 1 10:06:37 2022 +1100

    Add transition config method
@paulhauner paulhauner marked this pull request as ready for review March 7, 2022 22:29
@paulhauner paulhauner mentioned this pull request Mar 7, 2022
Closed
paulhauner added a commit that referenced this pull request Mar 7, 2022
@paulhauner
Squash merge of #3047
0659f7d 
Squashed commit of the following:

commit b5a711f
Author: Paul Hauner <[email protected]>
Date:   Fri Mar 4 13:10:57 2022 +1100

    Remove "number" rename

commit 3f287d0
Author: Paul Hauner <[email protected]>
Date:   Fri Mar 4 10:46:26 2022 +1100

    Fix method naming

commit b870f70
Author: Paul Hauner <[email protected]>
Date:   Tue Mar 1 10:06:37 2022 +1100

    Add transition config method
michaelsproul
michaelsproul approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo smol changes

beacon_node/execution_layer/src/lib.rs Outdated Show resolved Hide resolved
beacon_node/execution_layer/src/engine_api/http.rs Outdated Show resolved Hide resolved
paulhauner added a commit that referenced this pull request Mar 8, 2022
@paulhauner
Squash merge of #3047
e4c9d34 
Squashed commit of the following:

commit b5a711f
Author: Paul Hauner <[email protected]>
Date:   Fri Mar 4 13:10:57 2022 +1100

    Remove "number" rename

commit 3f287d0
Author: Paul Hauner <[email protected]>
Date:   Fri Mar 4 10:46:26 2022 +1100

    Fix method naming

commit b870f70
Author: Paul Hauner <[email protected]>
Date:   Tue Mar 1 10:06:37 2022 +1100

    Add transition config method
@paulhauner
Copy link
Member Author

paulhauner commented Mar 8, 2022 •
edited
Loading

Thanks for the review, all comments addressed 🙏

I've made three changes:

  • 8c83591: address review comments
  • 784851a: add a debug log when config handshake succeeds. I think this will be useful during testing to give confidence that we're connected to the EL and polling it.
  • ba7b012: add the transition config method to the integration tests. I had to shuffling things around to ensure we could detect a failure.

Edit: In ba7b012 I also made a change to support changes to Geth flags as per #3046 (comment).

michaelsproul
michaelsproul approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice, consider this re-reviewed!

@paulhauner
Copy link
Member Author

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Mar 8, 2022
bors bot pushed a commit that referenced this pull request Mar 8, 2022
@paulhauner
Poll the engine_exchangeTransitionConfigurationV1 endpoint (#3047)
3b4865c 
## Issue Addressed

There has been an [`engine_exchangetransitionconfigurationv1`](https://github.com/ethereum/execution-apis/blob/main/src/engine/specification.md#engine_exchangetransitionconfigurationv1) method added to the execution API specs.

The `engine_exchangetransitionconfigurationv1` will be polled every 60s as per this PR: ethereum/execution-apis#189. If that PR is merged as-is, then we will be matching the spec. If that PR *is not* merged, we are still fully compatible with the spec, but just doing more than we are required.

## Additional Info

- [x] ~~Blocked on #2837~~
- [x] Add method to EE integration tests
@bors
Copy link

bors bot commented Mar 8, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Poll the engine_exchangeTransitionConfigurationV1 endpoint [Merged by Bors] - Poll the engine_exchangeTransitionConfigurationV1 endpoint Mar 8, 2022
@bors bors bot closed this Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
bellatrix Required to support the Bellatrix Upgrade ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulhauner @michaelsproul