Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Use latest Geth release in EE integration tests #3395

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Use latest Geth release in EE integration tests #3395

wants to merge 2 commits into from

Conversation

paulhauner
Copy link
Member

@paulhauner paulhauner commented Aug 1, 2022 •
edited
Loading

Issue Addressed

NA

Proposed Changes

This PR reverts #3382 and adds the --syncmode=full as described here: #3382 (comment)

Additional Info

@paulhauner paulhauner added work-in-progress PR is a work-in-progress bellatrix Required to support the Bellatrix Upgrade labels Aug 1, 2022
@paulhauner paulhauner marked this pull request as ready for review August 1, 2022 03:10
@paulhauner paulhauner added blocked ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Aug 1, 2022
pawanjay176
pawanjay176 approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 3, 2022
@michaelsproul
Copy link
Member

Blocked on v2.5.1

@realbigsean
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 3, 2022
@paulhauner
Use latest Geth release in EE integration tests (#3395)
fe6af05 
## Issue Addressed

NA

## Proposed Changes

This PR reverts #3382 and adds the `--syncmode=full` as described here: #3382 (comment)

## Additional Info

- Blocked on #3392
@bors
Copy link

bors bot commented Aug 3, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Use latest Geth release in EE integration tests [Merged by Bors] - Use latest Geth release in EE integration tests Aug 3, 2022
@bors bors bot closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees
No one assigned
Labels
bellatrix Required to support the Bellatrix Upgrade ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulhauner @michaelsproul @realbigsean @pawanjay176