Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Pre-allocate vectors in SSZ decoding #3417

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Pre-allocate vectors in SSZ decoding #3417

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a687464
Pre-allocate vectors in SSZ decoding
michaelsproul Aug 3, 2022
14793ed
Merge remote-tracking branch 'origin/unstable' into pre-allocate-ssz-…
michaelsproul Aug 10, 2022
ce5ecf9
Clarify comment (thanks Sean)
michaelsproul Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions consensus/ssz/src/decode/try_from_iter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,18 @@ pub trait TryFromIter<T>: Sized {
impl<T> TryFromIter<T> for Vec<T> {
type Error = Infallible;

fn try_from_iter<I>(iter: I) -> Result<Self, Self::Error>
fn try_from_iter<I>(values: I) -> Result<Self, Self::Error>
where
I: IntoIterator<Item = T>,
{
Ok(Self::from_iter(iter))
// Pre-allocate the expected size of the Vec, which is parsed from the SSZ input bytes as
// `num_items`. This length has already been checked to be less than or equal to the type's
// maximum length in `decode_list_of_variable_length_items`.
let iter = values.into_iter();
let (_, opt_max_len) = iter.size_hint();
let mut vec = Vec::with_capacity(opt_max_len.unwrap_or(0));
vec.extend(iter);
Ok(vec)
}
}

Expand Down