[Merged by Bors] - Ensure validator/blinded_blocks/{slot} endpoint conforms to spec
#3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
added
bellatrix
macladson
changed the title
validator/blinded_block/{slot} endpoint conforms to specvalidator/blinded_blocks/{slot} endpoint conforms to spec
michaelsproul
approved these changes
Aug 5, 2022
michaelsproul
added
ready-for-merge
I do think we should eventually redesign the way we handle fork versioning in the API, but I think we can wait until more endpoints are affected. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 5, 2022
…3429) ## Issue Addressed #3418 ## Proposed Changes - Remove `eth/v2/validator/blinded_blocks/{slot}` as this endpoint does not exist in the spec. - Return `version` in the `eth/v1/validator/blinded_blocks/{slot}` endpoint. ## Additional Info Since this removes the `v2` endpoint, this is *technically* a breaking change, but as this does not exist in the spec users may or may not be relying on this. Depending on what we feel is appropriate, I'm happy to edit this so we keep the `v2` endpoint for now but simply bring the `v1` endpoint in line with `v2`.
bors
bot
changed the title
validator/blinded_blocks/{slot} endpoint conforms to specvalidator/blinded_blocks/{slot} endpoint conforms to spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#3418
Proposed Changes
eth/v2/validator/blinded_blocks/{slot}as this endpoint does not exist in the spec.versionin theeth/v1/validator/blinded_blocks/{slot}endpoint.Additional Info
Since this removes the
v2endpoint, this is technically a breaking change, but as this does not exist in the spec users may or may not be relying on this.Depending on what we feel is appropriate, I'm happy to edit this so we keep the
v2endpoint for now but simply bring thev1endpoint in line withv2.