Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: incorrectly formatted MEV link in Lighthouse Book #3434

Closed
wants to merge 2 commits into from

Conversation

BrendanTimmons
Copy link
Contributor

Issue Addressed

N/A

Proposed Changes

Simply fix the incorrect formatting on markdown link.

@CLAassistant
Copy link

CLAassistant commented Aug 8, 2022

CLA assistant check
All committers have signed the CLA.

@BrendanTimmons BrendanTimmons changed the title fix: incorrectly formatted MEV link fix: incorrectly formatted MEV link in Lighthouse Book Aug 8, 2022
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@realbigsean realbigsean changed the base branch from stable to unstable August 8, 2022 16:12
@michaelsproul michaelsproul added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Aug 8, 2022
@michaelsproul
Copy link
Member

@BrendanTimmons Could you please click through the contributor license agreement that the bot posted? 🙏 #3434 (comment). CI won't allow us to merge without that

Thanks!

@BrendanTimmons
Copy link
Contributor Author

@BrendanTimmons Could you please click through the contributor license agreement that the bot posted? 🙏 #3434 (comment). CI won't allow us to merge without that

Thanks!

Done!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 9, 2022
@michaelsproul
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Aug 9, 2022

👎 Rejected by PR status

book/src/builders.md Outdated Show resolved Hide resolved
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 9, 2022
## Issue Addressed

N/A

## Proposed Changes

Simply fix the incorrect formatting on markdown link.


Co-authored-by: Michael Sproul <[email protected]>
@bors bors bot changed the title fix: incorrectly formatted MEV link in Lighthouse Book [Merged by Bors] - fix: incorrectly formatted MEV link in Lighthouse Book Aug 9, 2022
@bors bors bot closed this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants