[Merged by Bors] - v3.0.0 #3464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
added
work-in-progress
|
|
|
I've just rebased this onto |
|
Once again, rebased on |
|
For those watching, the plan is to test this PR over the weekend and then publish a release Monday (AEST). |
|
We have had this running over the weekend on Prater and Mainnet on several nodes. I am happy with the amount of testing and I think we're good to review and merge 🎉 |
paulhauner
added
ready-for-review
michaelsproul
approved these changes
Aug 21, 2022
|
🚀 🐼 🚀 bors r+ |
|
Let's go! |
|
Build failed: |
|
spurious CI failure bors retry |
|
Build failed: |
|
bors retry |
michaelsproul
added
ready-for-merge
|
Build failed: |
|
Fix for cargo-udeps authored by @michaelsproul has been added in: 6ce9dc7 |
|
Lets just try bors again. bors r+ |
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
## Issue Addressed Resolves #3448 ## Proposed Changes Removes a known failure that wasn't actually a known failure. The tests declare this block invalid and we refuse to import it due to `ExecutionPayloadError(UnverifiedNonOptimisticCandidate)`. This is correct since there is only one "eth1" block included in this test and two are required to trigger the merge (pre- and post-TTD blocks). It is slot 1 (tick = 12s) when this block is imported so the import must be prevented by `SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY`. I'm not sure where I got the idea in #3448 that this test needed retrospective checking, that seems like a false assumption in hindsight. ## Additional Info - Blocked on #3464
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
## Issue Addressed NA ## Proposed Changes Indicate that local keystores are `readonly: Some(false)` rather than `None` via the `/eth/v1/keystores` method on the VC API. I'll mark this as backwards-incompat so we remember to mention it in the release notes. There aren't any type-level incompatibilities here, just a change in how Lighthouse responds to responses. ## Additional Info - Blocked on #3464
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed NA ## Proposed Changes Bump versions to v3.0.0 ## Additional Info - ~~Blocked on sigp#3439~~ - ~~Blocked on sigp#3459~~ - ~~Blocked on sigp#3463~~ - ~~Blocked on sigp#3462~~ - ~~Requires further testing~~ Co-authored-by: Michael Sproul <[email protected]>
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed Resolves sigp#3448 ## Proposed Changes Removes a known failure that wasn't actually a known failure. The tests declare this block invalid and we refuse to import it due to `ExecutionPayloadError(UnverifiedNonOptimisticCandidate)`. This is correct since there is only one "eth1" block included in this test and two are required to trigger the merge (pre- and post-TTD blocks). It is slot 1 (tick = 12s) when this block is imported so the import must be prevented by `SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY`. I'm not sure where I got the idea in sigp#3448 that this test needed retrospective checking, that seems like a false assumption in hindsight. ## Additional Info - Blocked on sigp#3464
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed NA ## Proposed Changes Indicate that local keystores are `readonly: Some(false)` rather than `None` via the `/eth/v1/keystores` method on the VC API. I'll mark this as backwards-incompat so we remember to mention it in the release notes. There aren't any type-level incompatibilities here, just a change in how Lighthouse responds to responses. ## Additional Info - Blocked on sigp#3464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Bump versions to v3.0.0
Additional Info
Blocked on [Merged by Bors] - Handle processing results of non faulty batches #3439Blocked on [Merged by Bors] - Fix lints for Rust 1.63 #3459Blocked on [Merged by Bors] - Increase merge-readiness lookhead #3463Blocked on [Merged by Bors] - Add mainnet merge values 🐼 #3462Requires further testing