-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Strict count unrealized #3522
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beacon_node/beacon_chain/src/schema_change/migration_schema_v7.rs
Outdated
Show resolved
Hide resolved
michaelsproul
added
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
v3.1.2
Release after v3.1.0 (formerly v3.1.1)
and removed
ready-for-review
The code is ready for review
labels
Aug 31, 2022
Co-authored-by: Michael Sproul <[email protected]>
realbigsean
added
ready-for-review
The code is ready for review
and removed
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
labels
Aug 31, 2022
michaelsproul
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magnifique. Let's ship this in v3.1.1
michaelsproul
added
blocked
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
blocked
labels
Aug 31, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 5, 2022
## Issue Addressed Add a flag that can increase count unrealized strictness, defaults to false ## Proposed Changes Please list or describe the changes introduced by this PR. ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: realbigsean <[email protected]> Co-authored-by: sean <[email protected]>
bors
bot
changed the title
Strict count unrealized
[Merged by Bors] - Strict count unrealized
Sep 5, 2022
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed Add a flag that can increase count unrealized strictness, defaults to false ## Proposed Changes Please list or describe the changes introduced by this PR. ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: realbigsean <[email protected]> Co-authored-by: sean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Add a flag that can increase count unrealized strictness, defaults to false
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.