Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Publish subscriptions to all beacon nodes #3529

Closed
wants to merge 14 commits into from

Conversation

pawanjay176
Copy link
Member

Issue Addressed

Resolves #3516

Proposed Changes

Adds a beacon fallback function for running a beacon node http query on all available fallbacks instead of returning on a first successful result. Uses the new run_on_all method for attestation and sync committee subscriptions.

Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.

@pawanjay176 pawanjay176 changed the title Publish all Publish subscriptions to all beacon nodes Aug 30, 2022
@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Aug 31, 2022
@pawanjay176 pawanjay176 requested a review from paulhauner August 31, 2022 23:04
@torfbolt
Copy link

torfbolt commented Sep 6, 2022

Also resolves #3422

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick passing review

Would be good to have tests for the CLI flag in lighthouse/tests/validator_client.rs

validator_client/src/cli.rs Outdated Show resolved Hide resolved
validator_client/src/config.rs Outdated Show resolved Hide resolved
validator_client/src/beacon_node_fallback.rs Outdated Show resolved Hide resolved
validator_client/src/beacon_node_fallback.rs Outdated Show resolved Hide resolved
validator_client/src/cli.rs Outdated Show resolved Hide resolved
validator_client/src/duties_service.rs Outdated Show resolved Hide resolved
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@realbigsean realbigsean added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 28, 2022
@realbigsean
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 28, 2022
## Issue Addressed

Resolves #3516 

## Proposed Changes

Adds a beacon fallback function for running a beacon node http query on all available fallbacks instead of returning on a first successful result. Uses the new `run_on_all` method for attestation and sync committee subscriptions. 

## Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.
@bors bors bot changed the title Publish subscriptions to all beacon nodes [Merged by Bors] - Publish subscriptions to all beacon nodes Sep 28, 2022
@bors bors bot closed this Sep 28, 2022
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

Resolves sigp#3516 

## Proposed Changes

Adds a beacon fallback function for running a beacon node http query on all available fallbacks instead of returning on a first successful result. Uses the new `run_on_all` method for attestation and sync committee subscriptions. 

## Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v3.2.0 Minor release following v3.1.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants