Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove strict fee recipient #3552

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Remove strict fee recipient #3552

wants to merge 4 commits into from

Conversation

realbigsean
Copy link
Member

@realbigsean realbigsean commented Sep 7, 2022 •
edited
Loading

Issue Addressed

Resolves: #3550

Remove the --strict-fee-recipient flag. It will cause missed proposals prior to the bellatrix transition.

@realbigsean realbigsean added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Sep 7, 2022
@michaelsproul michaelsproul added backwards-incompat Backwards-incompatible API change v3.1.2 Release after v3.1.0 (formerly v3.1.1) labels Sep 8, 2022
michaelsproul
michaelsproul approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we're good to merge this for v3.1.1 or v3.2.0 (whichever we decide on)

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 8, 2022
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 8, 2022
@realbigsean
Remove strict fee recipient (#3552)
a9f075c 
## Issue Addressed

Resolves: #3550

Remove the `--strict-fee-recipient` flag. It will cause missed proposals prior to the bellatrix transition.

Co-authored-by: realbigsean <[email protected]>
@bors
Copy link

bors bot commented Sep 9, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Remove strict fee recipient [Merged by Bors] - Remove strict fee recipient Sep 9, 2022
@bors bors bot closed this Sep 9, 2022
@realbigsean realbigsean deleted the remove-strict-fee-recipient branch November 21, 2023 16:16
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@realbigsean @Woodpile37
Remove strict fee recipient (sigp#3552)
29372c0 
## Issue Addressed

Resolves: sigp#3550

Remove the `--strict-fee-recipient` flag. It will cause missed proposals prior to the bellatrix transition.

Co-authored-by: realbigsean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
backwards-incompat Backwards-incompatible API change low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. v3.1.2 Release after v3.1.0 (formerly v3.1.1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realbigsean @michaelsproul @pawanjay176