Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add metric for re-org distance #3566

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add metric for re-org distance #3566

wants to merge 1 commit into from

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

Add a metric to track the re-org distance.

Additional Info

NA

@paulhauner paulhauner added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Sep 12, 2022
realbigsean
realbigsean reviewed Sep 12, 2022
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for using a gauge over a histogram?

@realbigsean realbigsean added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 12, 2022
@michaelsproul
Copy link
Member

I think a gauge is nicer because it's more precise. The default histogram buckets will ruin an integer value like the re-org distance. Related: if we want to set nicer histogram buckets we should merge #3391.

@realbigsean realbigsean added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 13, 2022
@realbigsean
Copy link
Member

makes sense to me!

@realbigsean
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 13, 2022
@paulhauner
Add metric for re-org distance (#3566)
7d3948c 
## Issue Addressed

NA

## Proposed Changes

Add a metric to track the re-org distance.

## Additional Info

NA
@realbigsean realbigsean added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 13, 2022
@bors
Copy link

bors bot commented Sep 13, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Add metric for re-org distance [Merged by Bors] - Add metric for re-org distance Sep 13, 2022
@bors bors bot closed this Sep 13, 2022
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@paulhauner @Woodpile37
Add metric for re-org distance (sigp#3566)
c5ec41f 
## Issue Addressed

NA

## Proposed Changes

Add a metric to track the re-org distance.

## Additional Info

NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realbigsean realbigsean realbigsean approved these changes

Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulhauner @michaelsproul @realbigsean