Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Use #!/usr/bin/env everywhere for local testnets #3606

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Use #!/usr/bin/env everywhere for local testnets #3606

wants to merge 1 commit into from

Conversation

tthebst
Copy link
Contributor

@tthebst tthebst commented Sep 25, 2022

Full local testnet support for people that don't have /bin/bash

michaelsproul
michaelsproul approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v3.2.0 Minor release following v3.1.2 labels Sep 26, 2022
@michaelsproul michaelsproul changed the base branch from stable to unstable September 27, 2022 04:10
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Sep 27, 2022
michaelsproul
michaelsproul requested changes Sep 27, 2022
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops just noticed that the target branch was wrong.

Do you mind rebasing on unstable and force pushing?

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 28, 2022
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 28, 2022
@tthebst
Use #!/usr/bin/env everywhere for local testnets (#3606)
3955b58 
Full local testnet support for people that don't have `/bin/bash`
@bors
Copy link

bors bot commented Sep 29, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 29, 2022
@tthebst
Use #!/usr/bin/env everywhere for local testnets (#3606)
6f5d4ae 
Full local testnet support for people that don't have `/bin/bash`
@michaelsproul
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Sep 29, 2022

Canceled.

@michaelsproul
Copy link
Member

re-batching

bors r+

bors bot pushed a commit that referenced this pull request Sep 29, 2022
@tthebst
Use #!/usr/bin/env everywhere for local testnets (#3606)
fcbdc8f 
Full local testnet support for people that don't have `/bin/bash`
@bors
Copy link

bors bot commented Sep 29, 2022

Build failed (retrying...):

@michaelsproul
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Sep 29, 2022

Canceled.

@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 29, 2022
@tthebst
Use #!/usr/bin/env everywhere for local testnets (#3606)
8d325e7 
Full local testnet support for people that don't have `/bin/bash`
@bors
Copy link

bors bot commented Sep 29, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Use #!/usr/bin/env everywhere for local testnets [Merged by Bors] - Use #!/usr/bin/env everywhere for local testnets Sep 29, 2022
@bors bors bot closed this Sep 29, 2022
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@tthebst @Woodpile37
Use #!/usr/bin/env everywhere for local testnets (sigp#3606)
a760dbf 
Full local testnet support for people that don't have `/bin/bash`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. v3.2.0 Minor release following v3.1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tthebst @michaelsproul