[Merged by Bors] - Add parent_block_number to payload SSE #4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
paulhauner
added
ready-for-merge
michaelsproul
commented
Mar 14, 2023
| @@ -47,7 +47,7 @@ use types::{ | |||
|
|
|||
| mod block_hash; | |||
| mod engine_api; | |||
| mod engines; | |||
| pub mod engines; | |||
There was a problem hiding this comment.
This is a sneaky change to support eleel.
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
## Issue Addressed In #4027 I forgot to add the `parent_block_number` to the payload attributes SSE. ## Proposed Changes Compute the parent block number while computing the pre-payload attributes. Pass it on to the SSE stream. ## Additional Info Not essential for v3.5.1 as I suspect most builders don't need the `parent_block_root`. I would like to use it for my dummy no-op builder however.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
## Issue Addressed In #4027 I forgot to add the `parent_block_number` to the payload attributes SSE. ## Proposed Changes Compute the parent block number while computing the pre-payload attributes. Pass it on to the SSE stream. ## Additional Info Not essential for v3.5.1 as I suspect most builders don't need the `parent_block_root`. I would like to use it for my dummy no-op builder however.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
## Issue Addressed In #4027 I forgot to add the `parent_block_number` to the payload attributes SSE. ## Proposed Changes Compute the parent block number while computing the pre-payload attributes. Pass it on to the SSE stream. ## Additional Info Not essential for v3.5.1 as I suspect most builders don't need the `parent_block_root`. I would like to use it for my dummy no-op builder however.
|
Pull request successfully merged into unstable. Build succeeded:
|
bors
bot
changed the title
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
In sigp#4027 I forgot to add the `parent_block_number` to the payload attributes SSE. Compute the parent block number while computing the pre-payload attributes. Pass it on to the SSE stream. Not essential for v3.5.1 as I suspect most builders don't need the `parent_block_root`. I would like to use it for my dummy no-op builder however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
In #4027 I forgot to add the
parent_block_numberto the payload attributes SSE.Proposed Changes
Compute the parent block number while computing the pre-payload attributes. Pass it on to the SSE stream.
Additional Info
Not essential for v3.5.1 as I suspect most builders don't need the
parent_block_root. I would like to use it for my dummy no-op builder however.