Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Restore upstream arbitrary #4372

Closed

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Jun 5, 2023

Proposed Changes

Remove patch for arbitrary in favour of upstream, now that the arithmetic_side_effects lint no longer triggers in derive macro code.

Additional Info

Blocked on Rust 1.71.0, to be released 13 July 23

@michaelsproul michaelsproul changed the title Upstream arbitrary and Rust 1.71 lints Restore upstream arbitrary Jul 18, 2023
@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! v4.4.1 ETA August 2023 code-quality and removed blocked work-in-progress PR is a work-in-progress do-not-merge labels Jul 18, 2023
@jimmygchen
Copy link
Member

Looks good and all tests passed 👍 🎉

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 19, 2023
@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 31, 2023
## Proposed Changes

Remove patch for `arbitrary` in favour of upstream, now that the `arithmetic_side_effects` lint no longer triggers in derive macro code.

## Additional Info

~~Blocked on Rust 1.71.0, to be released 13 July 23~~
@bors
Copy link

bors bot commented Jul 31, 2023

@bors bors bot changed the title Restore upstream arbitrary [Merged by Bors] - Restore upstream arbitrary Jul 31, 2023
@bors bors bot closed this Jul 31, 2023
@michaelsproul michaelsproul deleted the upstream-arbitrary branch July 31, 2023 04:02
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
Remove patch for `arbitrary` in favour of upstream, now that the `arithmetic_side_effects` lint no longer triggers in derive macro code.

~~Blocked on Rust 1.71.0, to be released 13 July 23~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. v4.4.1 ETA August 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants