Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove // from mev-rs patch section #4456

Closed

Conversation

michaelsproul
Copy link
Member

Issue Addressed

A user on Discord reported being unable to compile from source due to errors caused by the // in some of our Git dependency URLs.

$ make
cargo install --path lighthouse --force --locked \
        --features "jemalloc" \
        --profile "release" \

  Installing lighthouse v4.2.0 (/samsung_8tb_ssd/lighthouse/lighthouse)
    Updating git repository `https://github.com/ralexstokes//ethereum-consensus`
warning: spurious network error (3 tries remaining): remote error: 
 ralexstokes//ethereum-consensus is not a valid repository name
Visit https://support.github.com/ for help; class=Net (12)
warning: spurious network error (2 tries remaining): remote error: 
 ralexstokes//ethereum-consensus is not a valid repository name
Visit https://support.github.com/ for help; class=Net (12)
warning: spurious network error (1 tries remaining): remote error: 
 ralexstokes//ethereum-consensus is not a valid repository name
Visit https://support.github.com/ for help; class=Net (12)
error: failed to load source for dependency `ethereum-consensus`

I haven't been able to reproduce the error on my machine, but this may be due to hitting a different github.com server or some caching I'm unaware of (I tried deleting ~/.cargo/git/checkouts/<package> without success).

Proposed Changes

Use www.github.com to patch the deps instead of //. I'm not sure if we can remove the [patch] entirely until mev-rs does. I get weird circular errors about the package name being either ssz-rs or ssz_rs when I try to just pin the commits in the Cargo.toml.

Additional Info

@michaelsproul michaelsproul added ready-for-review The code is ready for review infra-ci labels Jul 2, 2023
@michaelsproul
Copy link
Member Author

Alex has published new upstream versions, so we can remove the patches entirely. I'll update this PR shortly.

@michaelsproul michaelsproul added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Jul 11, 2023
@michaelsproul
Copy link
Member Author

Closing this in favour of a new PR.

bors bot pushed a commit that referenced this pull request Jul 17, 2023
## Issue Addressed

Fixes occasional compilation errors with mev-rs (see #4456).

## Proposed Changes

- Update `mev-rs` to the latest version, which allows us to remove hacky `[patch]` sections
- Update the `axum` version used in `watch` so LH only uses a single version
@michaelsproul michaelsproul deleted the fix-mev-rs-patches branch July 17, 2023 02:58
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
Fixes occasional compilation errors with mev-rs (see sigp#4456).

- Update `mev-rs` to the latest version, which allows us to remove hacky `[patch]` sections
- Update the `axum` version used in `watch` so LH only uses a single version
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
Fixes occasional compilation errors with mev-rs (see sigp#4456).

- Update `mev-rs` to the latest version, which allows us to remove hacky `[patch]` sections
- Update the `axum` version used in `watch` so LH only uses a single version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci work-in-progress PR is a work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant