Remove // from mev-rs patch section #4456
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
A user on Discord reported being unable to compile from source due to errors caused by the
//
in some of our Git dependency URLs.I haven't been able to reproduce the error on my machine, but this may be due to hitting a different
github.com
server or some caching I'm unaware of (I tried deleting~/.cargo/git/checkouts/<package>
without success).Proposed Changes
Use
www.github.com
to patch the deps instead of//
. I'm not sure if we can remove the[patch]
entirely untilmev-rs
does. I get weird circular errors about the package name being eitherssz-rs
orssz_rs
when I try to just pin the commits in theCargo.toml
.Additional Info
mev-rs
issue: Fails to Build Due to Cargo Patch ralexstokes/mev-rs#91