[Merged by Bors] - Remove instances of required arguments with default values #4489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcph4
added
ready-for-review
paulhauner
added
ready-for-merge
jimmygchen
reviewed
Jul 11, 2023
|
bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make jmcph4 a reviewer |
That confirms it 😄 |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
## Issue Addressed #4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
|
Timed out. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
## Issue Addressed #4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
|
This PR was included in a batch that timed out, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
## Issue Addressed #4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
|
Build failed (retrying...): |
|
bors r+ |
|
Already running a review |
bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
## Issue Addressed #4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
|
This PR was included in a batch that timed out, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
## Issue Addressed #4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
## Issue Addressed #4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
|
bors r- |
|
Canceled. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
## Issue Addressed #4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
|
Build failed (retrying...): |
|
re-batching because of the simulator failure bors r- |
|
Canceled. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
## Issue Addressed #4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
|
This PR was included in a batch that timed out, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
## Issue Addressed #4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
|
Build failed (retrying...): |
|
bors r- |
|
Did you mean "r+"? |
|
bors r+ |
|
bors r- |
|
Canceled. |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
## Issue Addressed #4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
|
This PR was included in a batch that timed out, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
## Issue Addressed #4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
|
bors r- |
|
Canceled. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
## Issue Addressed #4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed sigp#4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed sigp#4488 ## Proposed Changes - Remove all instances of the `required` modifier where we have a default value specified for a subcommand ## Additional Info N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#4488
Proposed Changes
requiredmodifier where we have a default value specified for a subcommandAdditional Info
N/A