[Merged by Bors] - feat: add chiado #4530
Conversation
There was a problem hiding this comment.
Looks good to me, I'm happy to merge.
IMO, the biggest cost here is adding ~0.5mb to our Git history (genesis.ssz.zip) and ~3mb to our binary size (genesis.szz). The size of the binary will increase by less than 3%, which I think is manageable.
We could implement in-binary compression for the genesis states if we become particularly concerned about binary size.
paulhauner
added
ready-for-merge
|
Looks like we're failing CI sorry: |
|
I'm sorry, I don't really understand how / why this is happening. I get that the presets aren't compatible (that's by design), but the Gnosis mainnet one uses the same exact ones, and I'm not changing anything specific here. |
No worries, I think I found it. I would have made a code suggestion, but Github wouldn't allow me so I just pushed a commit with the fix: b35c1dc |
|
Hi, are we still waiting for anything regarding this? 🙂 |
|
I've made some changes to get this across the line for our v4.4.0 release (testing has already started!) Firstly, I had to remove four ENRs because they were causing Secondly, I removed the lighthouse bn --network chiado --genesis-state-url https://checkpoint.chiado.gnosis.gateway.fm |
## Issue Addressed N/A ## Proposed Changes Adds the Chiado (Gnosis testnet) network to the builtin one. ## Additional Info It's a fairly trivial change all things considered as the preset already exists, so shouldn't be hard to maintain. It compiles and seems to work, but I'm sure I missed something? Co-authored-by: Paul Hauner <[email protected]>
paulhauner
added
ready-for-merge
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
## Issue Addressed N/A ## Proposed Changes Adds the Chiado (Gnosis testnet) network to the builtin one. ## Additional Info It's a fairly trivial change all things considered as the preset already exists, so shouldn't be hard to maintain. It compiles and seems to work, but I'm sure I missed something? Co-authored-by: Paul Hauner <[email protected]>
## Issue Addressed N/A ## Proposed Changes Adds the Chiado (Gnosis testnet) network to the builtin one. ## Additional Info It's a fairly trivial change all things considered as the preset already exists, so shouldn't be hard to maintain. It compiles and seems to work, but I'm sure I missed something? Co-authored-by: Paul Hauner <[email protected]>
Issue Addressed
N/A
Proposed Changes
Adds the Chiado (Gnosis testnet) network to the builtin one.
Additional Info
It's a fairly trivial change all things considered as the preset already exists, so shouldn't be hard to maintain.
It compiles and seems to work, but I'm sure I missed something?