Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix Prefer Builder Flag #4622

Closed
wants to merge 1 commit into from

Conversation

ethDreamer
Copy link
Member

@ethDreamer ethDreamer commented Aug 15, 2023

No description provided.

@ethDreamer ethDreamer added bug Something isn't working v4.4.1 ETA August 2023 labels Aug 15, 2023
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks!

@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label Aug 17, 2023
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 18, 2023
@bors
Copy link

bors bot commented Aug 18, 2023

Build failed:

@michaelsproul
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Aug 18, 2023
@bors
Copy link

bors bot commented Aug 18, 2023

Build failed:

@michaelsproul
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Aug 18, 2023
@bors
Copy link

bors bot commented Aug 18, 2023

@bors bors bot changed the title Fix Prefer Builder Flag [Merged by Bors] - Fix Prefer Builder Flag Aug 18, 2023
@bors bors bot closed this Aug 18, 2023
bors bot pushed a commit that referenced this pull request Aug 21, 2023
## Issue Addressed

Fixes a bug in the handling of `--beacon-process-max-workers` which caused it to have no effect.

## Proposed Changes

For this PR I channeled @ethDreamer and saw deep into the faulty CLI config -- this bug is almost identical to the one Mark found and fixed in #4622.
@ethDreamer ethDreamer deleted the fix_perfer_builder_flag branch November 30, 2023 00:10
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

Fixes a bug in the handling of `--beacon-process-max-workers` which caused it to have no effect.

## Proposed Changes

For this PR I channeled @ethDreamer and saw deep into the faulty CLI config -- this bug is almost identical to the one Mark found and fixed in sigp#4622.
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

Fixes a bug in the handling of `--beacon-process-max-workers` which caused it to have no effect.

## Proposed Changes

For this PR I channeled @ethDreamer and saw deep into the faulty CLI config -- this bug is almost identical to the one Mark found and fixed in sigp#4622.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-for-merge This PR is ready to merge. v4.4.1 ETA August 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants