Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete deprecated cli flags #4906

Merged
merged 27 commits into from
Nov 9, 2023
Merged

Delete deprecated cli flags #4906

merged 27 commits into from
Nov 9, 2023

Conversation

chong-he
Copy link
Member

@chong-he chong-he commented Nov 7, 2023 •
edited
Loading

Delete deprecated cli flags as summarised below:

No. Deleted flag CLI Remark
1 --spec lighthouse bn --help
2 --eth1-endpoint lighthouse bn --help
3 --eth1-endpoints lighthouse bn --help
4 --beacon-node lighthouse vc --help
5 --server lighthouse vc --help
6 --delete-lockfiles lighthouse vc --help
7 --allow-unsynced lighthouse vc --help
8 --strict-fee-recipient lighthouse vc --help
9 --merge lighthouse bn --help hidden flag
10 --count-unrealized lighthouse bn --help hidden flag
11 --count-unrealized-full lighthouse bn --help hidden flag
12 --http-disable-legacy-spec lighthouse bn --help hidden flag
13 --minify lighthouse account validator slashing-protection import/export --help

@chong-he chong-he added the ready-for-review The code is ready for review label Nov 7, 2023
@chong-he chong-he added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Nov 7, 2023
@michaelsproul michaelsproul added backwards-incompat Backwards-incompatible API change code-quality labels Nov 8, 2023
michaelsproul
michaelsproul reviewed Nov 8, 2023
View reviewed changes
lcli/src/main.rs Outdated Show resolved Hide resolved
@chong-he chong-he added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Nov 8, 2023
michaelsproul
michaelsproul approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks CK!

Feels good to get rid of all this old baggage!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 8, 2023
@jimmygchen jimmygchen merged commit 7fd9389 into sigp:unstable Nov 9, 2023
23 checks passed
@chong-he chong-he deleted the delete-deprecated-cli branch December 3, 2023 09:40
@chenrui333 chenrui333 mentioned this pull request Jan 28, 2024
Merged
@michaelsproul michaelsproul mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
backwards-incompat Backwards-incompatible API change code-quality ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chong-he @michaelsproul @jimmygchen