-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set deneb fork on testnets #5089
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
# 40% | ||
PROPOSER_SCORE_BOOST: 40 | ||
# 20% | ||
REORG_HEAD_WEIGHT_THRESHOLD: 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, we don't define this in the lighthouse ChainSpec. Do we need to?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's defined on the mainnet one https://github.com/ethereum/consensus-specs/blob/3727a757450feb6110e2d4e403604572a478343d/configs/mainnet.yaml#L98-L100 but probably not used until
Squashed commit of the following: commit af19696 Author: realbigsean <[email protected]> Date: Thu Jan 18 22:01:53 2024 -0500 re-order fields in holesky commit 95f0623 Author: realbigsean <[email protected]> Date: Thu Jan 18 21:53:13 2024 -0500 set deneb fork on testnets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* set deneb fork on testnets * re-order fields in holesky
Issue Addressed
Setting some deneb forks!
Resolves #5055
I downloaded the config files these PRs/sources:
Holesky: eth-clients/holesky#94, eth-clients/holesky#95
Sepolia: eth-clients/sepolia#61
Chiado: https://github.com/gnosischain/configs/blob/main/chiado/config.yaml