Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set deneb fork on testnets #5089

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

realbigsean
Copy link
Member

@realbigsean realbigsean commented Jan 19, 2024

Issue Addressed

Setting some deneb forks!

Resolves #5055

I downloaded the config files these PRs/sources:

Holesky: eth-clients/holesky#94, eth-clients/holesky#95
Sepolia: eth-clients/sepolia#61
Chiado: https://github.com/gnosischain/configs/blob/main/chiado/config.yaml

@michaelsproul michaelsproul added the v4.6.0 ETA Q1 2024 label Jan 19, 2024
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

# 40%
PROPOSER_SCORE_BOOST: 40
# 20%
REORG_HEAD_WEIGHT_THRESHOLD: 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, we don't define this in the lighthouse ChainSpec. Do we need to?!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paulhauner added a commit that referenced this pull request Jan 19, 2024
Squashed commit of the following:

commit af19696
Author: realbigsean <[email protected]>
Date:   Thu Jan 18 22:01:53 2024 -0500

    re-order fields in holesky

commit 95f0623
Author: realbigsean <[email protected]>
Date:   Thu Jan 18 21:53:13 2024 -0500

    set deneb fork on testnets
@paulhauner paulhauner mentioned this pull request Jan 19, 2024
2 tasks
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realbigsean realbigsean added the ready-for-merge This PR is ready to merge. label Jan 20, 2024
@paulhauner paulhauner merged commit 70b0528 into sigp:unstable Jan 22, 2024
28 checks passed
danielrachi1 pushed a commit to danielrachi1/lighthouse that referenced this pull request Feb 14, 2024
* set deneb fork on testnets

* re-order fields in holesky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deneb ready-for-merge This PR is ready to merge. v4.6.0 ETA Q1 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants