Implement gossipsub IDONTWANT

[jxs]

Issue Addressed

implement IDONTWANT message sending and addressing when forwarding.
Follows libp2p/specs#548

Should be reviewed after #5401 is merged

[AgeManning]

Nice work. Just a few comments

[ackintosh]

I noticed that IDONTWANT control messages are not decoded while I was testing this. I think we should add some code here to decode IDONTWANT:

lighthouse/beacon_node/lighthouse_network/gossipsub/src/protocol.rs

Lines 419 to 491 in ae0b6b2

	if let Some(rpc_control) = rpc.control {
	// Collect the gossipsub control messages
	let ihave_msgs: Vec<ControlAction> = rpc_control
	.ihave
	.into_iter()
	.map(|ihave| {
	ControlAction::IHave(IHave {
	topic_hash: TopicHash::from_raw(ihave.topic_id.unwrap_or_default()),
	message_ids: ihave
	.message_ids
	.into_iter()
	.map(MessageId::from)
	.collect::<Vec<_>>(),
	})
	})
	.collect();
	let iwant_msgs: Vec<ControlAction> = rpc_control
	.iwant
	.into_iter()
	.map(|iwant| {
	ControlAction::IWant(IWant {
	message_ids: iwant
	.message_ids
	.into_iter()
	.map(MessageId::from)
	.collect::<Vec<_>>(),
	})
	})
	.collect();
	let graft_msgs: Vec<ControlAction> = rpc_control
	.graft
	.into_iter()
	.map(|graft| {
	ControlAction::Graft(Graft {
	topic_hash: TopicHash::from_raw(graft.topic_id.unwrap_or_default()),
	})
	})
	.collect();
	let mut prune_msgs = Vec::new();
	for prune in rpc_control.prune {
	// filter out invalid peers
	let peers = prune
	.peers
	.into_iter()
	.filter_map(|info| {
	info.peer_id
	.as_ref()
	.and_then(|id| PeerId::from_bytes(id).ok())
	.map(|peer_id|
	//TODO signedPeerRecord, see https://github.com/libp2p/specs/pull/217
	PeerInfo {
	peer_id: Some(peer_id),
	})
	})
	.collect::<Vec<PeerInfo>>();
	let topic_hash = TopicHash::from_raw(prune.topic_id.unwrap_or_default());
	prune_msgs.push(ControlAction::Prune(Prune {
	topic_hash,
	peers,
	backoff: prune.backoff,
	}));
	}
	control_msgs.extend(ihave_msgs);
	control_msgs.extend(iwant_msgs);
	control_msgs.extend(graft_msgs);
	control_msgs.extend(prune_msgs);
	}

[ackintosh]

@jxs @AgeManning I have submitted a PR to address the issue I previously mentioned. Could you please review it?

jxs#4

[AgeManning]

Yeah looks like you're right. We probably should have a test for this. I'll add the test and double check this corrects it. I'll push your changes to this branch

[jxs]

thanks @ackintosh!

[ackintosh]

@AgeManning @jxs I submitted a PR to address the failing tests. Could you please review it when you have a chance? 🙏

jxs#5

[AgeManning]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d46ac6c

[AgeManning]

Lets goo!

[AgeManning]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed