-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Goerli support #5770
Merged
Merged
Remove Goerli support #5770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
code-quality
backwards-incompat
Backwards-incompatible API change
labels
May 13, 2024
jimmygchen
reviewed
May 21, 2024
jimmygchen
added
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
and removed
ready-for-review
The code is ready for review
labels
May 21, 2024
jimmygchen
requested changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love deleting stuff 🎉 just a small comment above.
michaelsproul
added
ready-for-review
The code is ready for review
and removed
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
labels
May 27, 2024
jimmygchen
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jimmygchen
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
May 27, 2024
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 7f8b600 |
This was referenced May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backwards-incompat
Backwards-incompatible API change
code-quality
ready-for-merge
This PR is ready to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Goerli is dead and deprecated. This PR removes Goerli support from Lighthouse. Flags like
--network goerli
and--network prater
will no longer be accepted.Additional Info
The validator manager test vectors have been regenerated for Holesky. This required some portability fixes to the generator script.