Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress RPC Error disconnect log #5802

Merged
merged 1 commit into from
May 23, 2024
Merged

Suppress RPC Error disconnect log #5802

merged 1 commit into from
May 23, 2024

Conversation

dapplion
Copy link
Collaborator

Issue Addressed

Debugging das interop, noticed a noisy debug log:

May 17 06:12:23.708 DEBG RPC Error, direction: Outgoing, score: -0.7364966123883209, peer_id: 16Uiu2HAky14JjrYDFhkEjnVW9P8k8ysx87f4LcvzLRrVBnLEkqMU, client: Prysm: version: a1466d26b86470bab79e94c7d553033be4b8530e, os_version: unknown, err: G
racefully Disconnected, protocol: data_column_sidecars_by_root, service: libp2p, module: lighthouse_network::peer_manager:489
May 17 06:12:23.708 DEBG RPC Error, direction: Outgoing, score: -0.7364966123883209, peer_id: 16Uiu2HAky14JjrYDFhkEjnVW9P8k8ysx87f4LcvzLRrVBnLEkqMU, client: Prysm: version: a1466d26b86470bab79e94c7d553033be4b8530e, os_version: unknown, err: G
racefully Disconnected, protocol: data_column_sidecars_by_root, service: libp2p, module: lighthouse_network::peer_manager:489
May 17 06:12:23.708 DEBG RPC Error, direction: Outgoing, score: -0.7364966123883209, peer_id: 16Uiu2HAky14JjrYDFhkEjnVW9P8k8ysx87f4LcvzLRrVBnLEkqMU, client: Prysm: version: a1466d26b86470bab79e94c7d553033be4b8530e, os_version: unknown, err: G
racefully Disconnected, protocol: data_column_sidecars_by_root, service: libp2p, module: lighthouse_network::peer_manager:489
May 17 06:12:23.708 DEBG RPC Error, direction: Outgoing, score: -0.7364966123883209, peer_id: 16Uiu2HAky14JjrYDFhkEjnVW9P8k8ysx87f4LcvzLRrVBnLEkqMU, client: Prysm: version: a1466d26b86470bab79e94c7d553033be4b8530e, os_version: unknown, err: G
racefully Disconnected, protocol: data_column_sidecars_by_root, service: libp2p, module: lighthouse_network::peer_manager:489
May 17 06:12:23.708 DEBG RPC Error, direction: Outgoing, score: -0.7364966123883209, peer_id: 16Uiu2HAky14JjrYDFhkEjnVW9P8k8ysx87f4LcvzLRrVBnLEkqMU, client: Prysm: version: a1466d26b86470bab79e94c7d553033be4b8530e, os_version: unknown, err: G
racefully Disconnected, protocol: data_column_sidecars_by_root, service: libp2p, module: lighthouse_network::peer_manager:489
May 17 06:12:23.709 DEBG RPC Error, direction: Outgoing, score: -0.7364966123883209, peer_id: 16Uiu2HAky14JjrYDFhkEjnVW9P8k8ysx87f4LcvzLRrVBnLEkqMU, client: Prysm: version: a1466d26b86470bab79e94c7d553033be4b8530e, os_version: unknown, err: G
racefully Disconnected, protocol: data_column_sidecars_by_root, service: libp2p, module: lighthouse_network::peer_manager:489

This log is emitted from the peermanager, and is a consequence of allowing RPCError for disconnected peers through. If a peer disconnects and has 100 active ReqResp request, the log will appear 100 times.

Proposed Changes

If we allow to propagate the RPCError to the application, do not log it in the peer manager

@dapplion dapplion requested review from jimmygchen and AgeManning May 17, 2024 07:06
jimmygchen
jimmygchen approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jimmygchen
jimmygchen approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @AgeManning thoughts?

@jimmygchen jimmygchen added the ready-for-review The code is ready for review label May 17, 2024
@michaelsproul
Copy link
Member

Wrong Age 😅

@AgeManning

ackintosh
ackintosh approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@realbigsean
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented May 23, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 7073242

mergify bot added a commit that referenced this pull request May 23, 2024
@mergify
Merge of #5802
edf287f
@mergify mergify bot mentioned this pull request May 23, 2024
Closed
5 tasks
@mergify mergify bot merged commit 7073242 into sigp:unstable May 23, 2024
28 checks passed
@dapplion dapplion deleted the suppres-rpc-error-disconnect-log branch January 24, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackintosh ackintosh ackintosh approved these changes

@jimmygchen jimmygchen jimmygchen approved these changes

@AgeManning AgeManning Awaiting requested review from AgeManning

Assignees
No one assigned
Labels
ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dapplion @michaelsproul @realbigsean @jimmygchen @ackintosh