Add more info about why lookup is in AwaitingDownload #5838
Conversation
| @@ -397,7 +411,7 @@ impl<T: Clone> SingleLookupRequestState<T> { | |||
| }); | |||
| } | |||
| self.failed_downloading = self.failed_downloading.saturating_add(1); | |||
| self.state = State::AwaitingDownload; | |||
| self.state = State::AwaitingDownload("retry"); | |||
There was a problem hiding this comment.
Might be good to differentiate "retry after download failure" from "retry after processing failure"
There was a problem hiding this comment.
Changed to "not started" since it will never remain in that state
| pub fn update_awaiting_download_status(&mut self, new_status: &'static str) { | ||
| match &mut self.state { | ||
| State::AwaitingDownload(status) => *status = new_status, | ||
| _ => {} |
There was a problem hiding this comment.
looks like a lint is failing here
realbigsean
added
waiting-on-author
realbigsean
added
ready-for-merge
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
michaelsproul
added
waiting-on-author
|
needs an update |
…aiting-download-context
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 6a7305a |
jimmygchen
added
ready-for-merge
Issue Addressed
When debugging lookup stuck incidents in #5833, it's very helpful to know if the specific reason why a lookup is at the
AwaitingDownloadstate.Proposed Changes
As purely informational, append to
AwaitingDownloadenum variant the last reason why the lookup is at that state.