You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR bumps the default logfile-max-number from 5 to 10.
When the beacon node has a large number of validators attached to it, the log file gets filled up and sometimes gets rotated very quickly. This gets a bit worse if the node is overwhelmed / behind. It would be better if the debug logs can stay on the machine for at least 2~3 days, so that we have enough time to respond when an issue occurs. There's been multiple instances where we request logs from user and the old logs just got rotated out.
The current default limits the total logs stored on disk to 1Gb, this change would increase it to 2Gb, which isn't too bad.
🛑 The pull request has been removed from the queue default
The queue conditions cannot be satisfied due to failing checks.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment @mergifyio refresh on the pull request.
🛑 The pull request has been removed from the queue default
The queue conditions cannot be satisfied due to failing checks.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment @mergifyio refresh on the pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jimmygchen
added
ready-for-review
Issue Addressed
This PR bumps the default
logfile-max-numberfrom5to10.When the beacon node has a large number of validators attached to it, the log file gets filled up and sometimes gets rotated very quickly. This gets a bit worse if the node is overwhelmed / behind. It would be better if the debug logs can stay on the machine for at least 2~3 days, so that we have enough time to respond when an issue occurs. There's been multiple instances where we request logs from user and the old logs just got rotated out.
The current default limits the total logs stored on disk to 1Gb, this change would increase it to 2Gb, which isn't too bad.