Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PeerDAS presets and configs. #6127

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Add PeerDAS presets and configs. #6127

merged 2 commits into from
Jul 22, 2024

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Part of #6072

Proposed Changes

This PR pulls all presets and configs related changes from the das branch.

@jimmygchen jimmygchen added ready-for-review The code is ready for review das Data Availability Sampling das-unstable-merge labels Jul 18, 2024
pawanjay176
pawanjay176 requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except a config value

consensus/types/src/chain_spec.rs Outdated
@@ -1426,6 +1477,10 @@ const fn default_max_request_blob_sidecars() -> u64 {
768
}

const fn default_max_request_data_column_sidecars() -> u64 {
512
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec says 16384 🤔
https://github.com/ethereum/consensus-specs/blob/dev/configs/mainnet.yaml#L163

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed

realbigsean
realbigsean approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than pawan's comment

@jimmygchen jimmygchen requested a review from pawanjay176 July 19, 2024 02:13
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 19, 2024
@jimmygchen
Copy link
Member Author

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jul 19, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jul 19, 2024
@mergify
Merge of #6127
f574371
This was referenced Jul 19, 2024
Closed
Merged
@jimmygchen
Copy link
Member Author

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Jul 22, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Jul 22, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jul 22, 2024
@mergify
Merge of #6127
a1c2e35
@mergify mergify bot mentioned this pull request Jul 22, 2024
Closed
5 tasks
@jimmygchen
Copy link
Member Author

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Jul 22, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Jul 22, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jul 22, 2024
@mergify
Merge of #6127
3e5d3ea
This was referenced Jul 22, 2024
Closed
Merged
@jimmygchen
Copy link
Member Author

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Jul 22, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Jul 22, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 06dff60

mergify bot added a commit that referenced this pull request Jul 22, 2024
@mergify
Merge of #6127
90cd447
@mergify mergify bot mentioned this pull request Jul 22, 2024
Closed
5 tasks
@mergify mergify bot merged commit 06dff60 into sigp:unstable Jul 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

@realbigsean realbigsean realbigsean approved these changes

Assignees
No one assigned
Labels
das Data Availability Sampling das-unstable-merge ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmygchen @realbigsean @pawanjay176