Return syncing on HTTP when sync is stalled #6129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will add a test if we agree this approach is OK. |
|
Agree this approach makes more sense. In favor 👍 |
michaelsproul
changed the title
michaelsproul
added
ready-for-review
|
Added a test. Ready for review |
jimmygchen
approved these changes
Jul 19, 2024
jimmygchen
added
ready-for-merge
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 54e36f6 |
This was referenced Jul 19, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #6121:
Proposed Changes
The
syncingfield of/eth/v1/node/syncingwould befalsewhen sync is stalled (e.g. due to 0 peers). I think the intention of the API is to showsyncing: falseonly when the node is fully synced, so it is better if we returnsyncing: truefor a stall.In terms of liveness (e.g. a network where all BNs are stalled), the validator client will try requests even if its BN indicates that it is stalled. It might just try those BNs less preferentially.
Additional Info
Related liveness risk: