Correct ENR decoding on extension trait #6402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
approved these changes
Sep 17, 2024
|
Confirmed that discovery searches are working now. Added a commit to fix other occurrences of |
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
This was referenced Sep 19, 2024
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at a97d77c |
5 tasks
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
* Correct enr extension encodings * Clippy my ol friend * Correct all encoding and comparisons * Found some more encodings * Fix remaining tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6385 we upgraded to a new version of ENR. This version uses alloy-rlp. We have now explicit typing in decoding values to and from an ENR.
The previous update assumed
Vec<u8>would be decoded as bytes, but the alloy-rlp implements deocde forVec<T>as an RLP list. So it was trying to decode a list of u8's rather than raw bytes. As the eth2 and attestation fields are not RLP lists this decoding failed and we marked the ENRs as invalid.This should correct this issue by force the type to be
Bytesallowing us to decode the raw bytes in the ENR.