Fix subscribing to attestation subnets for aggregating (#6681) #6682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AgeManning
reviewed
Dec 11, 2024
michaelsproul
force-pushed
the
fix-subscribing-to-attestation-subnets
branch
from
461f7c1 to
1af5a84
Compare
michaelsproul
force-pushed
the
fix-subscribing-to-attestation-subnets
branch
from
1af5a84 to
978b2eb
Compare
|
Thanks for the fix @povi! I've rebased your commit on the |
povi
force-pushed
the
fix-subscribing-to-attestation-subnets
branch
from
978b2eb to
734ba35
Compare
* Prevent scheduled subnet subscriptions from being overwritten by other subscriptions from same subnet with additional scoping by slot
michaelsproul
force-pushed
the
fix-subscribing-to-attestation-subnets
branch
from
734ba35 to
7e44782
Compare
michaelsproul
approved these changes
Dec 12, 2024
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 4946343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#6681
Proposed Changes
Additionally scope scheduled subnet subscriptions by slot to prevent them from being overwritten by other same subnet subscriptions with different slots.